Change from Index to using name to set tabs on load

haavardj / ngx-cron-editor

Graphically build CRON expressions in Angular 15+

https://github.com/haavardj/ngx-cron-editor

MIT License

44 stars 101 forks source link

Change from Index to using name to set tabs on load #31

Closed AlexThomson95 closed 1 month ago

AlexThomson95 commented 8 months ago

Switching the setting of tabs on load from index to using the tab name

Might just need to test a little more

haavardj commented 7 months ago

The MatTabGroup implementation seems to be geared toward using tab index and not their names, so I'm not sure this is such a good idea.

On line 575 of cron-editor.component.ts, the this.tabGroup._allTabs should probably be considered private and not accessed from the component. Perhaps there is a different way of accomplishing this?

haavardj commented 1 month ago

We will keep the tab selection as is.