haavardj / ngx-cron-editor

Graphically build CRON expressions in Angular 15+
https://github.com/haavardj/ngx-cron-editor
MIT License
44 stars 101 forks source link

Updated to Angular 18; Angular Material 18 with Material Design 3 theme #42

Closed Aleksey-Yermolenko closed 1 month ago

haavardj commented 1 month ago

I get the following error when compiling the demo:

./apps/demo/src/styles.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
Can't find stylesheet to import.
  ╷
2 │ @use "ngx-cron-editor/theming" as cron-editor;
  │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  apps/demo/src/styles.scss 2:1  root stylesheet

Perhaps you forgot to a file?

haavardj commented 1 month ago

This PR became a bit messy. I have merged some of the changed suggestions here and updated the codebase for Material 3, as you suggested.

Aleksey-Yermolenko commented 1 month ago

I get the following error when compiling the demo:

./apps/demo/src/styles.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
Can't find stylesheet to import.
  ╷
2 │ @use "ngx-cron-editor/theming" as cron-editor;
  │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  apps/demo/src/styles.scss 2:1  root stylesheet

Perhaps you forgot to a file?

This error can occur if the demo app references an old version of the ngx-cron-editor package that didn't have a stylesheet. I'm running the demo app with npm link to avoid this issue:

npm run build ngx-cron-editor
cd dist/libs/ngx-cron-editor
npm link
cd ../../..
npm link ngx-cron-editor
npm run start