habamax / vim-godot

Use vim and godot engine to make games
MIT License
498 stars 24 forks source link

Improve s:run_scene #10

Closed Shatur closed 4 years ago

Shatur commented 4 years ago

Currently on Linux is not possible to run command async without plugins. xdg-open allows to open files or URL's. & is not works in Vim. So, I just removed this check. This will avoid error and allow ro run sync at least. I also reworked launch a bit. What do you think about it? Also I added support for Asyncrun. This plugin is very neat, it allow run command async and output everything in a quickfix like IDE in live: изображение

~P.S. I thinking about autosave feature. It would be nice to save all files automatically before running. What do you think? Should I put an option for autosave in this file too or in plugin folder?~

habamax commented 4 years ago

no autosave pls, if it is needed it could be turned on for vim by a user.

Shatur commented 4 years ago

~I meant as an option, not enabled by default. Sush as g:godot_save_before_run.~

Oh, I can just override a command manually in my vimrc. You are right.

Shatur commented 4 years ago

I reworded first message a bit to make it more clear :)

habamax commented 4 years ago

doesn't work in wsl tmux:

image

Shatur commented 4 years ago

Sorry, could you try again with the fix?

Shatur commented 4 years ago

What is your coding style for braces? I see that you sometimes use double quotes, sometime single quotes. I can't recognize a pattern :(

As I know it generally preferable to use single quotes for all places where you don't need to escape anything and double-quotes when you need to escape something.

habamax commented 4 years ago

thx!

coelhucas commented 3 years ago

Hey @Shatur95, I've just added AsyncRun but I'm not sure what I need to do in order to be able to see it working as my output instead of using Godot's one. Did I need to do any other setup-step? I'm currently on Ubuntu 20.04.

Shatur commented 3 years ago

@coelhucas, hi! No, it just should work.