habamax / wildcharm-theme

Dark and light Emacs themes
GNU General Public License v3.0
14 stars 3 forks source link

Support for `iedit` #4

Closed failable closed 1 year ago

failable commented 1 year ago

Since both iedit-occurrence and lsp-face-highlight-textual both inherit from highlight, when doing iedit-mode under a LSP highlighted symbol, the faces are indistinguishable which means that it's hard to make sure if iedit is successfully enabled (though the modeline contains indicator for that).

LSP highlighted:

Screenshot 2023-09-09 at 16 30 03

Note iedit is enabled in this case

Screenshot 2023-09-09 at 16 30 11
habamax commented 1 year ago

I don't use lsp-mode, but for eglot I have defined eglot-highlight-symbol-face. Let me add the same for lsp-mode, and I will rely on you to check it :)

habamax commented 1 year ago

could you please check?

failable commented 1 year ago

Looks good! Thanks!

Screenshot 2023-09-09 at 16 43 57