Only set HAVE_C11_STDATOMIC if we have the _Atomic keyword

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.

http://habanero-rice.github.io/hclib/

BSD 3-Clause "New" or "Revised" License

71 stars 35 forks source link

Only set HAVE_C11_STDATOMIC if we have the _Atomic keyword #47

Closed agrippa closed 7 years ago

agrippa commented 7 years ago

I found that the master build was broken on Edison because while icc 17.0.1 had stdatomic.h, it still didn't recognize _Atomic as a keyword. However, we were only checking for stdatomic.h before setting HAVE_C11_STDATOMIC.

agrippa commented 7 years ago

Not to be reviewed/merged before #46

DaoWen commented 7 years ago

I guess icc is using gcc's headers. This looks like a good workaround. 👍

agrippa commented 7 years ago

@budimlic ?

budimlic commented 7 years ago

Yep, this is a good workaround.

agrippa commented 7 years ago

@budimlic You can merge because you were the second to approve, per the contributor's agreement. I am not allowed to merge.