Fix pthread_setconcurrency warning

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.

http://habanero-rice.github.io/hclib/

BSD 3-Clause "New" or "Revised" License

71 stars 35 forks source link

Fix pthread_setconcurrency warning #49

Closed DaoWen closed 7 years ago

DaoWen commented 7 years ago

Ensure X/Open 6 features are enabled to avoid compiler warnings about undeclared functions on Linux.

agrippa commented 7 years ago

Have we ever actually seen pthread_setconcurrency improve performance? My understanding of it suggested that there aren't really any use cases where we'd expect it to help. What do you think? Should we just remove it?

This'll also be blocked until the merge guidelines can be integrated (like my two pull requests).

DaoWen commented 7 years ago

The comment above the call suggested that it helps when you have oversubscription, but after reading the POSIX documentation I think that's inaccurate. It looks like the call is only useful in "N:M" threading systems—which seem to have all died out in the POSIX world. Let's just delete it. I'll open a new pull request.