search

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.
http://habanero-rice.github.io/hclib/
BSD 3-Clause "New" or "Revised" License
71 stars 35 forks source link

Restructure installation process to place everything under a single install directory #66

Closed agrippa closed 5 years ago

agrippa commented 5 years ago

This change includes edits to the README to clarify the installation process, changes to installation process for modules so that they just go under the same HCLIB_ROOT directory, and updates to the code so that it looks for modules under $HCLIB_ROOT.

srirajpaul commented 5 years ago

Changes look good.

Few suggestions. Inside install.sh, the new added modules/system installation currently fails in a fresh system since HCLIB_ROOT is not set. This is happening with travis now. may be something like 'HCLIB_ROOT=${INSTALL_PREFIX} make install' would work.

Should we add the modules/system building in README.md ? Currently no Hclib program can without it.

Also we can remove the '- pushd modules/system && make && popd' from .travis.yml since it is taken care inside install.sh

agrippa commented 5 years ago

@srirajpaul good catch on the fresh install problem, I've fixed this in install.sh.

I've also added a short section on the module installation process in README.md.

srirajpaul commented 5 years ago

Looks good !!!