search

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.
http://habanero-rice.github.io/hclib/
BSD 3-Clause "New" or "Revised" License
71 stars 35 forks source link

adding basic examples for upcoming HiPC tutorial #67

Closed vivkumar closed 5 years ago

srirajpaul commented 5 years ago

Overall looks good. Few comments.

In case we are are planning for more extensive release of HClib, can we have a more hierarchical directory structure such as /test/tutorial/hipc18/cpp/... Or we can also keep the current structure if we plan to use almost the same tutorial.

Also as we discussed we can use wait() instead of wait_and_get() to make it future proof when wait_and_get gets removed.

test/tutorial/cpp/futures/graph.cpp many get calls, for example Line 28 a->get() does not wait for Task A to finish since futures do nothing w.r.t get(). Might want to use wait() there if we want to create a graph.

agrippa commented 5 years ago

@vivkumar what's the status of this? If I remember correctly, the tutorial is on the 20th, which means we're cutting this very tight. It's important to keep in mind the time zone that Sriraj and I are working on, in getting reviews back to you.

vivkumar commented 5 years ago

Apologies for delay. I am at HiPC and did not get time to look into this earlier. I just committed the updates.

agrippa commented 5 years ago

@vivkumar some final comments, mostly this looks great!

  1. Can we just move this entirely out of the test/ folder? These aren't really tests per se, so I'd rather just have a top-level tutorials/ folder (at the same level as test/) with a single hipc18 subfolder.
  2. I'm not sure why but one of the tests failed (doesn't seem like this is because of something in the code?). Hopefully, all the tests will pass with the directory structure change.