search

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.
http://habanero-rice.github.io/hclib/
BSD 3-Clause "New" or "Revised" License
71 stars 35 forks source link

Add support for variable number of futures to be passed to async_await #84

Closed agrippa closed 4 years ago

agrippa commented 4 years ago

@srirajpaul Could you take a look at this?

agrippa commented 4 years ago

@srirajpaul on the #ifdef: I think that sounds reasonable. Question is, do we enable or disable arbitrary numbers of futures by default?

I'd argue to keep it enabled by default as it's the most flexible option for new users/tutorials. Then, if more advanced people want to turn it off to get better performance and smaller task structs they can figure that out. But curious to hear what you think.

srirajpaul commented 4 years ago

I also thought of the same after adding the comment. We could keep the default option as enabling arbitrary numbers of futures for the same reasons. More advanced users can turn it off for performance-related requirements.

agrippa commented 4 years ago

@srirajpaul just added the compile-time flag to enable/disable this feature. Please take a look, as it's been a while since I added a new flag to the compile scripts.

srirajpaul commented 4 years ago

@agrippa The flag works as expected. Please go ahead and merge.