search

habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.
http://habanero-rice.github.io/hclib/
BSD 3-Clause "New" or "Revised" License
71 stars 35 forks source link

Make cmake the default build option #86

Closed srirajpaul closed 4 years ago

srirajpaul commented 4 years ago

Change the build system from Configure to cmake. The original configure scripts are retained and can be used with install_orig.sh, clean_orig.sh, README_orig.md. HClib applications/examples/test will continue to work with the earlier Makefile and also can be used with cmake scripts.

srirajpaul commented 4 years ago

@agrippa @ahayashi @Matthew-Whitlock @sbak5 Can you please take a look? This makes cmake the default build option for HClib and HClib_system. The earlier Makefile for applications/test will continue to work. test/cpp also includes a sample CMakeLists.txt that will serve as reference for later conversion of applications.

ahayashi commented 4 years ago

Thanks @srirajpaul, the PR looks good to me.

agrippa commented 4 years ago

@srirajpaul I'm no cmake expert but I'm pretty good with these changes. I'm sure we'll discover places where we want to add CMakeLists.txt files in the future but this is a great start.

Is it possible to rebase all of this in a single commit (once you've addresses/replied to my comments above)?

srirajpaul commented 4 years ago

@agrippa Regarding rebasing. Do you want me to rebase all the commits into a single commit or you want to use the "squash and merge" option in github to do it while merging a pull-request?

agrippa commented 4 years ago

@srirajpaul ah, i didn't realize there was a github feature for that. if that's easier then i'm good with that. this looks ready to merge to me.