habanero-rice / hclib

A C/C++ task-based programming model for shared memory and distributed parallel computing.
http://habanero-rice.github.io/hclib/
BSD 3-Clause "New" or "Revised" License
71 stars 35 forks source link

Add a std::vector<>* variant of async await, set CRAYPE_LINK_TYPE to install script to make building on Cray machines simpler #89

Closed agrippa closed 4 years ago

agrippa commented 4 years ago

@srirajpaul just a couple of small changes related to the herds project. Do you see any problem just setting CRAYPE_LINK_TYPE in the install script?

srirajpaul commented 4 years ago

@agrippa Adding CRAYPE_LINK_TYPE to install script should not be a problem, since it won't set it directly to the global environment. Only case is if user does 'source install.sh', then it will be added to the global environment, but we do not suggest using source. Also CRAYPE_LINK_TYPE should not cause any problem in non-cray machines.