search

habitat-sh / core-plans

Core Habitat Plan definitions
130 stars 252 forks source link

[mongodb] core/mongodb contains debug symbols #1912

Open jsirex opened 6 years ago

jsirex commented 6 years ago

Something bad happened with core/mongodb/3.6.4:

╰─○ du -shc *
2.7G    bin
4.0K    BUILD_DEPS
4.0K    BUILD_TDEPS
4.0K    CFLAGS
20K     config
4.0K    CPPFLAGS
4.0K    CXXFLAGS
8.0K    default.toml
4.0K    DEPS
4.0K    EXPORTS
4.0K    EXPOSES
4.0K    FILES
8.0K    hooks
4.0K    IDENT
4.0K    include
4.0K    LDFLAGS
4.0K    LD_RUN_PATH
4.0K    lib
8.0K    MANIFEST
4.0K    PATH
4.0K    run
4.0K    RUNTIME_ENVIRONMENT
4.0K    RUNTIME_PATH
4.0K    SVC_GROUP
4.0K    SVC_USER
4.0K    TARGET
4.0K    TDEPS
4.0K    TYPE
2.7G    total
drwxr-xr-x 2 root root 4.0K Jul 17 07:05 .
drwxr-xr-x 7 root root 4.0K Jul 17 07:06 ..
-rwxr-xr-x 1 root root 5.7K Jul 17 07:05 install_compass
-rwxr-xr-x 1 root root 378M Jul 17 07:05 mongo
-rwxr-xr-x 1 root root 933M Jul 17 07:05 mongod
-rwxr-xr-x 1 root root 919M Jul 17 07:05 mongoperf
-rwxr-xr-x 1 root root 465M Jul 17 07:05 mongos
mongod: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /hab/pkgs/core/glibc/2.27/20180608041157/lib/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=3526d69b39bf0dd2c02eb30dcf67e7ea8d8038a2, with debug_info, not stripped

https://github.com/habitat-sh/core-plans/commit/035024e5197449954d0debc566f131f81e2d09ad

predominant commented 6 years ago

The stripping operation caused the binary to not work. So I added the do_strip() implementation. I'll take another look at building it again shortly. Thanks @jsirex !