habitat-sh / habitat-operator

A Kubernetes operator for Habitat services
Apache License 2.0
61 stars 17 forks source link

[version] Display version when booting operator #350

Closed surajssd closed 6 years ago

surajssd commented 6 years ago

Operator shows it's version when it starts. This version information is embedded inside the binary while building it. It is a good practice to show the operator version when it is booting up.

Fixes https://github.com/habitat-sh/habitat-operator/issues/348

surajssd commented 6 years ago

@krnowak I did not understand the part where you are saying

And our release steps will need to be extended with a check for a proper version of the operator.

krnowak commented 6 years ago

I did not understand the part where you are saying

@surajssd: Basically, when doing a release of the operator, we want to make sure that the version it prints is something like v0.7.2, not v0.7.2-31-g9eae1e5d nor v0.7.2-31-g9eae1e5d-dirty nor v0.7.2-dirty.

surajssd commented 6 years ago

@krnowak

And our release steps will need to be extended with a check for a proper version of the operator.

this is done :-)

krnowak commented 6 years ago

LFAD if tests pass.