habitat-sh / habitat

Modern applications with built-in automation
https://www.habitat.sh
Apache License 2.0
2.61k stars 315 forks source link

Run lifecycle hooks asynchronously #5329

Open christophermaier opened 6 years ago

christophermaier commented 6 years ago

Description

Lifecycle hooks currently run synchronously in the main Supervisor loop. This is Bad(TM), because it leaves open the possibility of a misbehaving hook of one service to block the loop for everyone. When this happens the supervisor will no longer respond to commands or be able to manage any other services until that hook completes.

It would be better to handle this asynchronously.

Acceptance Criteria

christophermaier commented 6 years ago

Related to https://github.com/habitat-sh/habitat/issues/1973

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.