habitat-sh / habitat

Modern applications with built-in automation
https://www.habitat.sh
Apache License 2.0
2.61k stars 315 forks source link

Container Exporter: Support generic repository push option #7693

Open christophermaier opened 4 years ago

christophermaier commented 4 years ago

We officially support three different repository destinations when pushing an image during a hab pkg export container run: docker, amazon, and azure. However, this is a bit misleading.

In reality, you can push to arbitrary repositories by lying and claiming they're Azure; just provide the right URL, username, and password (in fact, if you provide the username "AWS" and use the token from aws ecr get-login-password as your password, you can pass your ECR URL, claim this is Azure, and upload to Amazon without a problem).

The only time we really need a hint about what kind of repository we're pushing to is the Amazon case, and you want to use the same credentials over a long period of time (as from Builder).

We should simplify all this, and expose the fact that you can use any repository you want, not just Docker, Amazon, or Azure.

Aha! Link: https://chef.aha.io/features/APPDL-116

christophermaier commented 4 years ago

The code around managing these credentials in the exporter should be significantly cleaned up during this work, as well.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.