search

habitus-eu / HabitusGUI

Rshiny GUI
Apache License 2.0
3 stars 4 forks source link

Path to conda executable must be general #68

Closed emolinaro closed 1 year ago

emolinaro commented 1 year ago

https://github.com/habitus-eu/HabitusGUI/blob/9092df1a1b6ecc028b29dc82239e894f85c5c54e/R/PALMSpyshiny.R#L13

vincentvanhees commented 1 year ago

This line is correct, because it is only supposed to be used by me to test the app locally. On UCloud when username is 'shiny' or 'ucloud' the command should use this line: https://github.com/habitus-eu/HabitusGUI/blob/9092df1a1b6ecc028b29dc82239e894f85c5c54e/R/PALMSpyshiny.R#L16

As a result the full command send to the system should be consistent with what we had before except the addition of the unbuffer argument as I explained in my e-mail: To use the unbuffer argument we will need to add the expect library to the dependencies.

Note that there is an open issue for making the hard-coded path on line 13 more generic: https://github.com/habitus-eu/HabitusGUI/issues/66 However, this should not affect usage on UCloud as the line is not intended for UCloud, it is only for local testing in an R environment where PALMSpy can only be reached by a conda environment.

emolinaro commented 1 year ago

Ok, there is no problem when launching the app from UCloud. I close this issue.