Sort of a big pull request - Githubissues

habnabit / txsocksx

SOCKS{4,4a,5} endpoints for twisted

ISC License

58 stars 37 forks source link

Sort of a big pull request #1

Closed hellais closed 11 years ago

hellais commented 11 years ago

It would be great if you were to give me some feedback on the changes I made to txsocksx and possible merge them.

The major changes are:

Use parsley for parsing (as you suggested on IRC)
Do not depend on qbuf

Some specific question that perhaps you can give advice on is:

https://github.com/hellais/txsocksx/blob/master/txsocksx/client.py#L35

TODO

Test Authentication (I believe it is currently broken)
Expand unittests and restore the previously working ones
Test SSL wrapper

Thanks

habnabit commented 11 years ago

superseded by #3.