search

habnabit / txsocksx

SOCKS{4,4a,5} endpoints for twisted
ISC License
58 stars 37 forks source link

where is socks 4,4a support #4

Closed infinity0 closed 11 years ago

infinity0 commented 11 years ago

I might be missing something obvious, but where is the support for SOCKS 4/4a? It is advertised in the repo description ("SOCKS {4,4a,5} endpoints for twisted") but I don't see it anywhere in the source code...

habnabit commented 11 years ago

4 and 4a support were in the original code that txsocksx was derived from, but were not carried along during the split out into a separate project. Some of the support already exists, but full 4/4a support is not yet complete.

habnabit commented 11 years ago

4a8807a68b0dcc371c38db39f7bc065c7267de9d contains an example of the SOCKS4 code I just added. Does this work for you?

infinity0 commented 11 years ago 
pkg_resources.VersionConflict: (Parsley 1.1 (/usr/lib/python2.7/dist-packages), Requirement.parse('Parsley>=1.2'))

Where are you getting 1.2 from, bzr HEAD?

infinity0 commented 11 years ago

ah I see https://github.com/washort/parsley - looks like the debian package is out of date.

infinity0 commented 11 years ago

Thanks - that code seems to work for a simple basic case, but my more complex code seems to be causing twisted to busy-loop. Not sure if that is txsocksx's problem, though.

infinity0 commented 11 years ago

copypasta from IRC

17:11:11 <infinity0> my thing works if i set bufSize smaller in abstract.py
17:11:16 <infinity0> and it still uses a shit load of CPU
17:11:48 <infinity0> the underlying issue is that the SOCKS client receives data back from the remote endpoint 1 byte at a time
17:11:52 <_habnabit> infinity0, it's probably actually a parsley performance issue
17:13:07 <_habnabit> well, it's kind of a combination of a few different things
17:13:21 <_habnabit> i think i have a fix, though
habnabit commented 11 years ago

SOCKS4 support is fixed by 4a8807a68b0dcc371c38db39f7bc065c7267de9d and the performance by 03d2441e085fd709395f38424d9ca7ba9bba730e.