search

habnabit / vcversioner

take version numbers from version control
ISC License
28 stars 16 forks source link

Allow option for developmental releases defined in PEP 440. #9

Open tylercrumpton opened 8 years ago

tylercrumpton commented 8 years ago

Fixes #8. I'm willing to change the name of the option or make any tweaks as necessary.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 5aafadef9170d5d93ab362f7d61a57b038f370a7 on tylercrumpton:master into 72f8f0a7e0121cf5989a2cb00d5e1395e02a0445 on habnabit:master.

tylercrumpton commented 7 years ago

Any thoughts on pulling this request in?

habnabit commented 7 years ago

Really sorry. I'm trying to schedule time so I can get around to all of my currently-neglected projects.

cgroschupp commented 7 years ago

@habnabit I would also need this feature, can I somehow support?

habnabit commented 7 years ago

So sorry I haven't set aside time to review this yet. I'm going to schedule some for tonight.

On Tue, Feb 7, 2017 at 10:49 AM, Tyler Crumpton notifications@github.com wrote:

@tylercrumpton commented on this pull request.

In vcversioner.py https://github.com/habnabit/vcversioner/pull/9:

@@ -73,6 +74,14 @@ def find_version(include_dev_version=True, root='%(pwd)s', the version number will be 1.0.post3. This behavior can be disabled by setting this parameter to False.

  • :param use_dev_not_post: PEP 440 states that versions created during
  • development cycles should use the .dev suffix instead of .post.
  • This suffix can be used by setting this parameter to True. This
  • suffix references a corresponding future release, so vcversioner will
  • assume that the future release is a single version higher than the
  • current commit. For example, if the current commit is one revision past
  • the 2.0.1 tag, the computed version will be 2.0.2dev1.

@Julian https://github.com/Julian Any thoughts on this? I can add the lambda current: next_version if that feels required to move forward.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/habnabit/vcversioner/pull/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AABSsF3Cu46HDKiS7jsYmRJ45guq59h8ks5raLyjgaJpZM4JBvm8 .

tylercrumpton commented 7 years ago

@habnabit @Julian Did either of you get a chance to take a look at this? We've been using this option for a while now and love how it has improved our CI process. 😃

Julian commented 7 years ago

The idea is +1 from me I think, though I haven't read PEP 440 close enough to be sure, but it's @habnabit's opinion that matters :) (Sorry for the wait :/)

tylercrumpton commented 7 years ago

Hey, just wanted to give a gentle ping 😄 This is still a feature that we use constantly and would love to see it in the official project!

tylercrumpton commented 6 years ago

Hey there! Any new thoughts on pulling in something like this?

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a30f32e09b1ac08c3b7ccf4a9f1559a1248df381 on tylercrumpton:master into 72f8f0a7e0121cf5989a2cb00d5e1395e02a0445 on habnabit:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 204a28dfe00ca5564b0242b39eed8ed4fd1aca74 on tylercrumpton:master into 72f8f0a7e0121cf5989a2cb00d5e1395e02a0445 on habnabit:master.

tylercrumpton commented 6 years ago

Ack, sorry for the commit/rebuild noise here! I forgot that this PR was based off of tylercrumpton/vcversioner@master, so a change I was playing with got yanked in by accident. Should be reverted out now, and the PR can be squashed if we still want to pull the dev-version changes in.