version parameter only relevant for XMl response writer


This is minor, but in Service.php the version is always added to the query
string in public function search():

        $params['version'] = self::SOLR_VERSION;

There are 2 problems with this.  Frist, as best I can tell from the Solr
documentation and the source code of the JSON response writer, the version
parameter is not used by the JSON writer at all.  It only seems to be used
by the XML writer:

http://wiki.apache.org/solr/XMLResponseFormat#version

That page also list valid versions as 2.0, 2.1, and 2.2 (though the source
code for that writer actually just treats anything < 2.1 the same).

but Service.php defines:  

    /**
     * Response version we support
     */
    const SOLR_VERSION = '1.2';

It seems like this 'version' param can be simply removed, or at least
omitted if the request writer type is not 'xml'.

Original issue reported on code.google.com by pwola...@gmail.com on 15 Nov 2009 at 1:30

hacioguz / solr-php-client

version parameter only relevant for XMl response writer #23