[General] General Improvements

1Mateus commented 3 months ago

Common Issues

[x] Shortened versions of hashes should have a “copy to clipboard” button, resulting in copying the full value.
[x] If the server responds with an error, often an empty result is displayed instead of an error page.
[x] The eye icons in the last column of tables do not link anywhere (they should link to the appropriate details page).
[x] The URL does not change for pagination or for tabs on details pages.

Top Bar

[x] The search bar is missing on every page (so functionality from Kadscan - Header Search Flows 1-2 slides of Figma is missing from the implementation).
[x] Labels of dropdown items in the top bar menu should also link somewhere.

Home Screen

[x] For unsuccessful searches, the Loading… message is displayed indefinitely instead of No result found (as designed in the prototype).
[x] The checkmark (or x) could also link to the transaction page like the request key value.
[x] Daily percent change is missing from the circulating supply indicator.

Recent Transactions

[x] - The gas amount could be presented in KDA (taking into account the current gas price).

Error Page (https://www.kadscan.io/error)

[x] The gradient in the background is missing.

Blocks (https://www.kadscan.io/blocks)

Recent Blocks

[x] Missing link in the last column.
[x] The error message is poorly worded: `No recent blocks found yet. We couldn't find any recent blocks.
[x] In an erroneous state, it is not possible to display the first page again (probably an issue of routing).

Block Details - Block Transactions

[x] Rows do not link to transaction details.

Transactions (https://www.kadscan.io/transactions)

[x] The state of the pagination is not reflected in the URL.
[x] The transaction table is missing the recipient column (again, it could be the number of recipients).
[x] The eye icon is not linking anywhere (expecting it to link to the transaction details page).

Transaction Details

[x] The Code field should have a “copy to clipboard” button.
[x] Block Height should link to block details.
[x] Fields with accounts should link to account details.
[x] In the Transaction Output tab, the result field is presented as JSON. In the Figma prototype, we have a graphical representation of the value.

Account

Account Details

[x] The URL is the same whichever tab is opened.
[x] I inspected the state of the request, and the server is responding with a 503 error, but this is not reported in the frontend. Instead, an empty result is displayed, which is frustrating for the user.

Tokens

Token Transfers (https://www.kadscan.io/tokens)

[x] The eye icon in the last column is not linking anywhere.
[x] The name and icon of the token should link to that Token Detail page.

Trending Tokens (https://www.kadscan.io/tokens/trending)

[x] Only a minor issue: the Price column could be aligned to the left like in the prototype. Also, it is not clear what the ordering in the table is.

Tokens Details

[x] The transfer amount column is missing the token symbol (i.e., we have 0.00004343 instead of 0.0004343 KDA). Token Details - Info
[x] I would expect the label of the market data source to link to the source’s page.

NFT

[x] Since there is only one item in the NFT menu right now, we should just link the NFT label to the NFT Transfers page until the trending collections page is ready.
[x] The eye icon does not link anywhere.

1Mateus commented 3 months ago

@bernardonery @rafaeldkb

Sobre o item: "The name and icon of the token should link to that Token Detail page"

O marcin ta comparando a integração que fizemos com a coin gecko, onde a gente consegue de fato buscar dados de determinados tokens, como uma descrição, um nome oficial, links oficiais, toda a parte de ETL (gráficos e relatórios).

Mas isso é limitado aos dados que estão disponível sobre a blockchain deles: https://www.coingecko.com/en/chains/kadena

Dessa forma, não é possível somente redirecionar o usuário para todos os tokens, podemos sim redirecionar para os que estão disponíveis na coingecko, mas não seria todos. Teria que validar como funcionaria no design.

1Mateus commented 3 months ago

@bernardonery @rafaeldkb

Sobre o item: " Daily percent change is missing from the circulating supply indicator."

Esse valor não tem na API da Coingecko.

bernardonery commented 3 months ago

Noted

rafaeldkb commented 3 months ago

Fiquei em dúvida só nessa aqui "In the Transaction Output tab, the result field is presented as JSON. In the Figma prototype, we have a graphical representation of the value." No caso, tá marcado como check, mas ainda tá aparecendo como JSON, né? @1Mateus

1Mateus commented 3 months ago

@rafaeldkb sim, a diferença é só o objeto vai ta aberto ou minificado, só arrumei a view.

Agora ta igual ao design.

1Mateus commented 3 months ago

hack-a-chain-software / indexer-kadena