search

hack-chat / hackchat-client

The default client that is webpacked and distributed in the `main` repository
Do What The F*ck You Want To Public License
28 stars 15 forks source link

Event notifications #17

Open marzavec opened 3 years ago

marzavec commented 3 years ago

Notifications need to be added. I was thinking of using react-web-notification for compatibility reasons and it's built-in service worker handling.

Notifications should be built to check if the window has focus, as well as what channel currently has focus, allowing mentions in other background channels to be displayed.

KnowsCount commented 3 years ago

sounds should play a big role in the notification part, concluding from my past experience using hack.chat. some sort of clearer reminder, at least. but as stated in react-web-notification:

Notification.sound Notification.sound is not supported in any browser. You can emulate it with onShow callback. see example.

there might be issues with sound... can this be solved?—I am personally not quite familiar with this notification thingy.

marzavec commented 3 years ago

can this be solved?

Yep, should be easy enough, compatibility will be the biggest hurdle though.