search

hack-chat / main

a minimal, distraction-free chat application
https://hack.chat/
1.31k stars 222 forks source link

Fixed themes and alphabetized them. #240

Open MattMadness opened 4 months ago

MattMadness commented 4 months ago

I noticed some new themes had popped up in the last few months and I decided it would be a good idea to alphabetize them, and also fix major and minor issues with some of the themes (i.e. an image not loading, the sidebar in the retro theme entirely reversed and full of whitespace, etc.). I've tested these changes and they seem to be working fine, and I'm open to any recommendations.

MattMadness commented 4 months ago

I decided I modified the retro theme too much so I added a solution so that the settings are more obvious. Basically, when the mouse is hovering over the sidebar, the settings will appear under the nicklist. Otherwise it'll just show the nicks. It's better than a bunch of whitespace in my opinion LOL. I hope it suffices!

xyzpw commented 4 months ago

@MattMadness The nebula and Ubuntu theme appear as intended — none of them are bugged.

FFUV commented 4 months ago

@MattMadness I quit hack.chat for a reasons I would not like to discuss, I do not want you touching the waifu theme besides the makima.svg that is the only thing I want you to "fix" because I intended the waifu.css theme to look as it is its not bugged it was supposed to be an inside joke as I'm bad at programming I made it purposely bad.

AnnikaV9 commented 4 months ago

I feel like since people treat their themes personally, modifying them randomly in bulk is not a good way to go about it, even if said themes have issues. My recommendation would be to create a separate repo for unofficial user themes, and keep official polished themes in this repo. Maybe adding a functionality in the sidebar to import themes from the unofficial theme repo.

marzavec commented 4 months ago

@MattMadness This is a great PR! Nothing wrong with it; aligns us closer to the "self hosted" goal. Even still, would you be willing to revert changes on ubuntu.css and nebula.css? Along with the partial revert request from @FFUV?

FFUV commented 4 months ago

@xyzpw still got beef with me eh?

xyzpw commented 4 months ago

@FFUV

it was supposed to be an inside joke as I'm bad at programming I made it purposely bad

Seemed quite lame, but no "beef."

MattMadness commented 4 months ago

Thanks for the input. I'm worried this is going to be controversial as well, so I'd like to say by no means am I married to his idea, but perhaps we could keep the newer variants of nebula and ubuntu as nebula-ng and ubuntu-ng, respectively. If this idea does not sit well, I shall remove those schemes and push the changes.

AnnikaV9 commented 4 months ago

@marzavec Having purposefully broken "inside joke" themes in the main codebase isn't really a good idea. Themes here should be polished and "official". Official themes wouldn't be tied to a single author, and improvements can be made whenever necessary without upsetting anyone. Community themes should be loaded externally, through extensions, another repo, etc. If let's say hack.chat's user base suddenly grows a lot for whatever reason, we can't just have hundreds of themes committed here. So I would suggest having a system where community and official themes are separate. It doesn't have to be a second repo, that was just one of the solutions I could think of.

AnnikaV9 commented 4 months ago

Currently, authors treat their themes like they own them, and there's nothing wrong with that. But it makes it harder to improve a theme without upsetting its author.

MattMadness commented 4 months ago

@MattMadness I quit hack.chat for a reasons I would not like to discuss, I do not want you touching the waifu theme besides the makima.svg that is the only thing I want you to "fix" because I intended the waifu.css theme to look as it is its not bugged it was supposed to be an inside joke as I'm bad at programming I made it purposely bad.

You're not that bad. I believe you can make a better theme with the makima.svg addition, and you can contribute to my branch before this ends. There's no reason to downplay yourself. You can do better.

FFUV commented 4 months ago

@MattMadness I quit hack.chat for a reasons I would not like to discuss, I do not want you touching the waifu theme besides the makima.svg that is the only thing I want you to "fix" because I intended the waifu.css theme to look as it is its not bugged it was supposed to be an inside joke as I'm bad at programming I made it purposely bad.

You're not that bad. I believe you can make a better theme with the makima.svg addition, and you can contribute to my branch before this ends. There's no reason to downplay yourself. You can do better.

Alright you have my full permission to mess with my theme I will addon to it later.

Edit: Only make good changes that are needed no unnecessary changes please!