search

hack-dance / island-ai

https://island.novy.work
MIT License
125 stars 11 forks source link

Publish declaration maps so goto definition works properly #47

Closed natdempk closed 6 months ago

natdempk commented 7 months ago

👋

I was trying to use this library a bit and understand the the types/source. It is a bit hard in VSCode because jump to definition takes you to a TS declaration file or a compiled JS file today.

This PR adds the TS compiler option to publish declaration maps which fixes this issue, making developer experience better: https://www.typescriptlang.org/tsconfig#declarationMap

It would maybe be nice to cut a release with these enabled if its not a hassle so they actually get published.

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 1fc5b38a79f7ddb79bcb28a64f2bcc3ad9e62d1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
island-ai-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 0:50am
roodboi commented 6 months ago

I'm generally for this update. There were some issues with tsup not respecting the option, and it required some workaround, either running it with tsc post build or using some other set of options—I never dug in too deep.

did you confirm this working with a build?

https://github.com/egoist/tsup/issues/885 there's a few threads but this one seems to have some somewhat recent activity

roodboi commented 6 months ago

There are some issues with creating declaration maps with tsup - going to close, but if you want to open an issue or take a stab at figuring out a reasonable workaround, happy to take a look - but this is going to require some build updates to get working

natdempk commented 6 months ago

👍 Thanks, yeah no worries. Also looked at the tsup issue and workarounds a bit here and it seemed like support was non-trivial.