[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If you
are working in this fork the source branch should be feature/<username>/<topic> merging into
hack-different/iwpndfu:next (left side). Don't request your main!
[ ] Rebase to main locally to prevent messy commits. This can be done from the PR.
[x] This may sound obvious but get a device out and test that the program works. (One day we
may have better test infrastructure but for now this is required)
[ ] Check the commit's message styles matches our requested structure.
And no profanity in commit messages as they go out to Discord / are immutable.
[ ] Link your PR to an open GitHub issue to ensure that the rationale is not repeated and the
issue is closed when the PR is accepted. (Must be done in body of the PR not in title)
[ ] Check your code additions will fail neither code linting checks nor unit test. This is done by
setting up pre-commit in your local workspace. GitHub actions will also verify quality and will
prevent you from merging without it.
dora2-iOS
commented
2 years ago
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
feature/<username>/<topic>merging intohack-different/iwpndfu:next(left side). Don't request yourmain!mainlocally to prevent messy commits. This can be done from the PR.commit's message styles matches our requested structure. And no profanity in commit messages as they go out to Discord / are immutable.pre-commitin your local workspace. GitHub actions will also verify quality and will prevent you from merging without it.❤️Thank you!