hack-gpon / hack-gpon.github.io

https://hack-gpon.org/
MIT License
154 stars 81 forks source link

CIG (Q-010G-Q) password generator not accessible #252

Closed systemcrash closed 1 year ago

systemcrash commented 1 year ago

Tried to generate a password for my NOKIA ONT Q-010G-Q, which has a serial beginning: ALCL then 4 (hex) bytes, as opposed to GPON:

ALCLXXXXXXXX

But that's a problem for:

https://cigpassword.hack-gpon.org/?serial=GPONabc12345&username=ONTUSER

Something that can/must be fixed?

simonebortolin commented 1 year ago

Can you show a screenshot of the probem?

The link work

systemcrash commented 1 year ago

Can you show a screenshot of the probem?

The link work

has a serial ALCLXXXXXXXX

GPON S/N in format GPONabc12345
Please provide a valid GPON S/N. 
stich86 commented 1 year ago

Have you used lower letters after GPON VID?

So if your serial is GPONAABBCC you should write it like this/ GPONaabbcc

nanomad commented 1 year ago

Seems to be working just fine. image

You can join the telegram group then message me and we will check why yours is not working. The link is at the top of the website

systemcrash commented 1 year ago

The error message is entirely misleading, and conflates the lower-case problem (a-z) with the requirement that it starts with GPON.

Is it difficult to strlower or similar in the code? Or does the code function for various devices and one cannot make this assumption?

nanomad commented 1 year ago

The error message is entirely misleading, and conflates the lower-case problem (a-z) with the requirement that it starts with GPON.

Is it difficult to strlower or similar in the code? Or does the code function for various devices and one cannot make this assumption?

Agreed, a fix is in the works :)

systemcrash commented 1 year ago

And/Or write a less confusing error message, like: If your device serial is ASDFABCDEF10 - please enter ASDFabcdef10

systemcrash commented 1 year ago

Lower-case for the HEX part seems to work. 👍 Thanks for the help.

nanomad commented 1 year ago

Lower-case for the HEX part seems to work. 👍 Thanks for the help.

Feel free to try the API now. It should give the same output with any case you put

systemcrash commented 1 year ago

"should"

GPON S/N in format GPONabc12345
Please provide a valid GPON S/N. 
nanomad commented 1 year ago

My fault :) Missed a manual deploy step. I'll update the issue once it's done

nanomad commented 1 year ago

@systemcrash backend and front-end both updated. Let me know if we can mark this as resolved

image

systemcrash commented 1 year ago

Seems good, although the success/failure messages are a bit terse.

GPON S/N in format GPONabc12345

simonebortolin commented 1 year ago

please, suggest an alterative text

nanomad commented 1 year ago

@simonebortolin here's what I would do

simonebortolin commented 1 year ago

@nanomad point 1 is acceptable, but there is also a need to make the same change on several other forms and/or delete the submit button itself and do it as in the eeprom form with vue.

for point 2 and 3 ummh makes sense, let's wait for @systemcrash's opinion

simonebortolin commented 1 year ago

@systemcrash you can also have a look at the other form in the web-site, third-party opinions are always welcome

systemcrash commented 1 year ago

How about: Unrecognized GPON S/N format. S/N are typically of the form XXXXDEADBEEF, where XXXX is commonly GPON or ALCL.

( Now that we have resolved the lettering case problem )