Closed YuukiJapanTech closed 1 year ago
Thanks @YuukiJapanTech ! I'll add some details to your contribution during the day as long as I find more things. For example, I have a newer software version than yours.
Preview of the website obtained from the PR: https://d10f9d83.hack-gpon-preview.pages.dev
@YuukiJapanTech the "ONT fs.com" link in the sidebar under XGS PON doesn't link to the right page @simonebortolin Shouldn't we just leave FS.com?
Preview of the website obtained from the PR: https://6c78e909.hack-gpon-preview.pages.dev
@nanomad
@YuukiJapanTech the "ONT fs.com" link in the sidebar under XGS PON doesn't link to the right page @simonebortolin Shouldn't we just leave FS.com?
I fixed the problem, it was a series of 3 problems fixed in the commits.
Preview of the website obtained from the PR: https://397d0bff.hack-gpon-preview.pages.dev
@YuukiJapanTech this is the template for the generic ONU/ONT page: https://github.com/hack-gpon/hack-gpon.github.io/blob/main/_ont/ont-template.md please try to respect it as much as possible (order, titles, etc.)
@simonebortolin Thanks for sharing the template! sorry, overlooked it. I will modify it to be compliant.
@YuukiJapanTech I created a PR against your branch with versions and the CLI command tree. Do you mind merging it when you have some time? Thank you.
@alvgalrus if you want to do a shared PR, you are more likely to have both write permissions in the same repo, because it is possible that we also ask for changes to non-@YuukiJapanTech things.
Hi, I modified it to comply with the template, please check it. (and CLI tree PR added, thanks)
Added @alvgalrus as a collaborator for CA8271x.
In an hour I'll look at it
Preview of the website obtained from the PR: https://33ccd36a.hack-gpon-preview.pages.dev
Preview of the website obtained from the PR: https://2dd4978b.hack-gpon-preview.pages.dev
@nanomad Thanks, fixed it. Is the table still broken? (I don't know why it's broken...)
Preview of the website obtained from the PR: https://08a72021.hack-gpon-preview.pages.dev
@nanomad Thanks, fixed it. Is the table still broken? (I don't know why it's broken...)
It is fixed
@nanomad thanks. Sorry..., the form factor and loid were wrong so I fixed it.
Fixes except PassGen, ont-fs-XGS-ONU-25-20NI-cli.md. (sorry, I'm going on vacation for a while from tomorrow⛩️, so the corrections will be delayed~ )
(sorry, I'm going on vacation for a while from tomorrow⛩️, so the corrections will be delayed~ )
me from Monday
I will now look and finish the review
with this I finished the PR, I would say it is already very good as it is, with a few changes it will be completed and more consistent without losing quality or information
Preview of the website obtained from the PR: https://7b293542.hack-gpon-preview.pages.dev
I'll take a look to what's left between today and tomorrow.
@simonebortolin thanks, I fixed. please check it. Thanks for creating the PassGen form!!
@YuukiJapanTech please marge with main branch ASAP for testing the form
Preview of the website obtained from the PR: https://1f73963b.hack-gpon-preview.pages.dev
@simonebortolin My apologies. synced the forks.
@YuukiJapanTech No problem, no need to apologize
Everything seems almost ready
@simonebortolin thanks. CIG and ECIN redirects don't work well, am I doing something wrong...?
Preview of the website obtained from the PR: https://378a4e90.hack-gpon-preview.pages.dev
I fixed it so that redirects work. (/ont~ > /xgs/ont~)
@nanomad thanks, fixed it.
Preview of the website obtained from the PR: https://9741e6a5.hack-gpon-preview.pages.dev
@simonebortolin Fixed. please make sure.
Preview of the website obtained from the PR: https://f5e5f5f5.hack-gpon-preview.pages.dev
sorry it's very long and I don't always see things straight away
I added the latest changes from code review to a PR and some more things I saw while editing the file. Waiting for @YuukiJapanTech to approve the changes to this PR's branch since it's protected.
Preview of the website obtained from the PR: https://11de782a.hack-gpon-preview.pages.dev
@nanomad or @ErnyTech give one last check, then you can merge
ok, thanks for check.
@YuukiJapanTech @alvgalrus thank you very much
added FS XGS-ONU-25-20NI (CA8271x) Port the GitHub CA8271x(https://github.com/YuukiJapanTech/CA8271x) article.