fix: fix field alignment to avoid panics on 32bit OSes

hairyhenderson commented 4 months ago

Fixes #43

To solve this, I:

enabled the fieldalignment linter (which is a sub-linter of govet)
ran the fieldalignment -fix command to fix misaligned structs that were non-obvious
switch from using e.g. int64 + atomic.StoreInt64 to using atomic.Int64 (etc) and because of this...
drop Go 1.18 support, and require Go 1.19+ (where the new atomic types were introduced)
added a new CI job to test in a 32-bit container (so far just Intel 386, which should catch the same bugs as arm32/etc)
added some new tests to cover keyvalue/blob.Bytes, which was what was giving me trouble initially

hairyhenderson commented 4 months ago

If at all possible, my strong preference is to maintain field ordering in the table driven test case types

I can revert the test files, no big deal.

hairyhenderson commented 4 months ago

@JohnStarich thanks for the feedback, I think I've addressed it all - please have another look!

(I'm not sure why coveralls thinks the coverage decreased - I added new tests... ¯\_(ツ)_/¯)

hack-pad / hackpadfs