Simplify 32 bit CI workflow & lint, test on Go 1.19-1.22

hack-pad / hackpadfs

An extensible file system abstraction for Go. File systems, composable interfaces, and test suites.

Apache License 2.0

254 stars 11 forks source link

Simplify 32 bit CI workflow & lint, test on Go 1.19-1.22 #45

Closed JohnStarich closed 4 months ago

JohnStarich commented 4 months ago

A couple changes to simplify various workflows, plus explicitly testing on the latest Go versions.

Enable race on all supported platforms, explicitly set -race= flag
Move linters-settings below linters list
Reformat octal integers to latest gofmt style
Fix comments to strictly follow godoc style
Disable govet's fieldalignment memory size check on test files
Test on Go 1.19-1.22, verify 32 bit field alignment on Linux with latest Go

JohnStarich commented 4 months ago

I've changed up how the architecture is passed in, since I hit issues with installing other test dependencies (wasmbrowsertest) when the GOHOSTARCH was not the native arch.

I reverified we're still catching the field alignment issues with 8ede24a:

--- FAIL: TestChmod (0.00s)
panic: unaligned 64-bit atomic operation [recovered]
    panic: unaligned 64-bit atomic operation