search

hack4impact-calpoly / general-vms

General volunteer management system.
2 stars 0 forks source link

feat: added Shift endpoint and Shift interface #31

Closed adameza closed 2 years ago

adameza commented 2 years ago

issue #11, I added placeholders for the 'Database' abstract class and the 'isUserAdmin' middleware function. The implementation was pretty much just to make the linter happy. 'shift-api' and 'shift-interface' are the real features.

bglossner commented 2 years ago

Also, sorry one more comment: make sure to write some unit tests!

bglossner commented 2 years ago

Glad to see a PR out for this. Good first iteration on the task!

adameza commented 2 years ago

@bglossner got the tests to work with the express router. I have omitted the isUserAdmin middleware function because the tests are required to pass for a commit.

adameza commented 2 years ago

@bglossner split up the tests and did without the getShiftTime() function