search

hack4impact-calpoly / general-vms

General volunteer management system.
2 stars 0 forks source link

Implementation of Navbar / Footer #32

Closed khoa-l closed 2 years ago

khoa-l commented 2 years ago

I thought it'd be best to carry over the design of the CalPoly Hack4Impact site for a general purpose vms. There's still some things to work out, and it'll definitely change, but let me know if this doesn't work.

I also had some issues with the App.test.tsx, so I had to change that to get this pushed, but if someone could let me know why the original test didn't work for this implementation, it'd be appreciated.

bglossner commented 2 years ago

This is an awesome first revision! The colors look nice and we have most of the content we'd need. A couple thoughts:

I see this when I pull and render the page: image.

I cannot see the photo for the org logo. The footer is also not stuck to the bottom of the page (I don't mean "sticky" by this but for content that doesn't hit the bottom of the page, our footer should still be positioned at the bottom. For content more than 100% of the height, the footer should not be viewable unless the user scrolls).

Another sorta small thing is it seems like React now recommends importing images and other assets through src rather than public so that webpack bundles it (things in public do not get bundled by default). Using ../../ relative paths like that outside the src directory may lead to errors later on. I would make a src/assets/images directory and src/assets/fonts directory and move the appropriate types of media in each from public. From there, we can use relative URLs that are in reference to things in src.

bglossner commented 2 years ago

Can you also remove .DS_Store (git rm --cached .DS_Store) and add .DS_Store to the .gitignore?

I am also a little nervous to see changes to package-lock.json for the backend, as you didn't modify anything in the backend package.json.

khoa-l commented 2 years ago

Added requested changes. For some reason the image is still not loading, I don't know if I'm missing something, but I'll try to figure that out.