hack4impact-mcgill / MADA-v2

5 stars 2 forks source link

password reset #140

Open selenajin99 opened 1 year ago

KihyeokK commented 1 year ago

Resetting password works, but I get the following error when clicking cancel after resetting password in another tab is done:image

KihyeokK commented 1 year ago

After resetting password from the profile page, I get this error when I try to access another page.

Screenshot 2023-06-24 at 5 47 16 PM

KihyeokK commented 1 year ago

After reset password button is clicked, it would be nice to get a message confirming that an email is sent, since it looks like no event happens from the user's perspective after clicking the button.

KihyeokK commented 1 year ago

In the reset password page, it would be nice to get a notification message saying that password reset was successful, and also letting the user know that they can close the tab now.

sophearahsp commented 1 year ago

@KihyeokK Added notification messages and the errors seem to be fixed. Please check the changes again

KihyeokK commented 1 year ago

@KihyeokK Added notification messages and the errors seem to be fixed. Please check the changes again

Ok will try to check the changes maybe this Tuesday or Wednesday, have been a bit busy lately

KihyeokK commented 1 year ago

@sophearahsp thanks for the notification messages, they work well👍

KihyeokK commented 1 year ago

@sophearahsp Regarding the errors, now I see when the error actually occurs. It happens when the user tries to reset password once again by accessing the previously sent reset-password link. This breaks everything, with ERROR] 01:20:29 Error: Invalid or expired password reset token error log from postgres container. I think we should somehow block the user from accessing the old reset-password link or block sending the reset request once again with the expired reset token.

sophearahsp commented 1 year ago

@sophearahsp Regarding the errors, now I see when the error actually occurs. It happens when the user tries to reset password once again by accessing the previously sent reset-password link. This breaks everything, with ERROR] 01:20:29 Error: Invalid or expired password reset token error log from postgres container. I think we should somehow block the user from accessing the old reset-password link or block sending the reset request once again with the expired reset token.

Ahh okay. Should it automatically send a new request when using an expired link? Or just not break anything when coming across this error? @KihyeokK

KihyeokK commented 1 year ago

@sophearahsp Regarding the errors, now I see when the error actually occurs. It happens when the user tries to reset password once again by accessing the previously sent reset-password link. This breaks everything, with ERROR] 01:20:29 Error: Invalid or expired password reset token error log from postgres container. I think we should somehow block the user from accessing the old reset-password link or block sending the reset request once again with the expired reset token.

Ahh okay. Should it automatically send a new request when using an expired link? Or just not break anything when coming across this error? @KihyeokK

I think either approach is fine, as long as the user doesn't use the expired link/token to reset password. What are your thoughts @selenajin99 ?

selenajin99 commented 1 year ago

@sophearahsp Regarding the errors, now I see when the error actually occurs. It happens when the user tries to reset password once again by accessing the previously sent reset-password link. This breaks everything, with ERROR] 01:20:29 Error: Invalid or expired password reset token error log from postgres container. I think we should somehow block the user from accessing the old reset-password link or block sending the reset request once again with the expired reset token.

Ahh okay. Should it automatically send a new request when using an expired link? Or just not break anything when coming across this error? @KihyeokK

I think either approach is fine, as long as the user doesn't use the expired link/token to reset password. What are your thoughts @selenajin99 ?

oops I didn't see this until now, I think it would be easier if we just display expired link, new link is sent to your email and have the user redo the process.