hack4impact-mcgill / MADA

Repository for the MADA Project
5 stars 0 forks source link

Add Volunteer/Admin user models #20

Closed peterghrong closed 2 years ago

peterghrong commented 2 years ago

Description

Add Volunteer/Admin User models, I skipped api because there were a few things that I am not too sure about.

Questions:

  1. User is missing a password field in the class diagram, wondering if I should add that.
  2. Some routes should probably be admin access only, users probably shouldnt have access to the admin route, wondering what you think of that.
  3. Need some more issues open to point directions : ) am lazy.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Checklist:

kehwhy commented 2 years ago

Code looks good! I'll try to get another reviewer to check it as well.

As for API: