hack4impact-mcgill / mu-crm-tool

1 stars 3 forks source link

Add Contact Route Test Cases #96

Closed dgiltz closed 3 years ago

dgiltz commented 3 years ago

Summary

Write a quick summary of your changes here. Make sure to provide context for people that may be unfamiliar with what you're working on!

Test Plan

How did you test your changes?

Related Issues

Which issues does this PR resolve/work on? Closes #

CurtisMIT commented 3 years ago

@dgiltz I think you can add the tests in #94 to test your changes there.

celinehuang commented 3 years ago

If you're hoping to break the task down into smaller PRs then it's better to group the endpoints and their tests in a PR vs. separating all the tests in another PR because how else are you running the tests to test your endpoints 🤔 We are writing test cases because we want to see if the assumed behaviour for our endpoints is indeed what we are getting - run test via this command python manage.py --config development test

ex. create a contact + unit test = a PR edit a contact + unit test = a PR get all contacts for a specific project + unit test = a PR

CurtisMIT commented 3 years ago

Closing as @dgiltz has moved it to #115 and #119 .