Closed josh-byster closed 5 years ago
Yeah Iād like a Mac/Linux user to test this also to make sure it just works out of the box and Iām not implicitly pulling any environment variables the way Iām doing it now.
I'm not sure if this would work with deployment using zeit now - maybe test that as well. All the current docker stuff is set up for zeit now deployment, which is why you see this
FROM mhart/alpine-node:10.7.0 as build
The purpose of the multi stage builds is so the final image isn't big, since now has a size limit.
What I would do is I would make another Dockerfile, something like Dockerfile.dev
and use that with docker compose.
I'm not sure if this would work with deployment using zeit now - maybe test that as well. All the current docker stuff is set up for zeit now deployment
Ah, didn't see that we were using v1 deployments instead of serverless v2 functions. We can easily create a Dockerfile-dev
in the backend that Compose pulls from instead, leaving the existing Dockerfile
as-is. What are your thoughts @tko22?
The purpose of the multi stage builds is so the final image isn't big, since now has a size limit.
What I would do is I would make another Dockerfile, something like
Dockerfile.dev
and use that with docker compose.
Yes, I agree ā I don't think we can use the same image built for Now since we need the dev dependencies for development. I changed the Dockerfile since I thought it was no longer used, but now that I know it's being used to deploy BE, I created a separate file that builds a development image.
Ah, didn't see that we were using v1 deployments instead of serverless v2 functions. We can easily create a Dockerfile-dev in the backend that Compose pulls from instead, leaving the existing Dockerfile as-is. What are your thoughts @tko22?
Yep sounds good
Resolves #260
This change allows us to run the frontend and backend all at once with no installation needed, just one command:
docker-compose up
! š Also we have the uniformity and reproducibility of bugs among all our developers using Docker with this change.This is meant to be run in a dev environment, so we use volumes to allow changes made locally to be reflected in the container.
This also addresses factoring out environment variables (fix #328)