Open anoshaminai opened 8 years ago
@anoshaminai bump on making sure conflicts with master are resolved
@sandlerben Addressed comments, also I thought I addressed conflicts but apparently not. When I call 'git merge origin/master' it says everything is up to date - what else do I need to do?
Did you fetch first?
On Thu, May 19, 2016, 7:35 PM Anosha Minai notifications@github.com wrote:
@sandlerben https://github.com/sandlerben Addressed comments, also I thought I addressed conflicts but apparently not. When I call 'git merge origin/master' it says everything is up to date - what else do I need to do?
—
You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/hack4impact/transcribe4all/pull/36#issuecomment-220477418
You received this message because you are subscribed to the Google Groups "hack4impact-exec-2016-17" group. To unsubscribe from this group and stop receiving emails from it, send an email to hack4impact-exec-2016-17+unsubscribe@googlegroups.com. To post to this group, send email to hack4impact-exec-2016-17@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hack4impact-exec-2016-17/hack4impact/transcribe4all/pull/36/c220477418%40github.com https://groups.google.com/d/msgid/hack4impact-exec-2016-17/hack4impact/transcribe4all/pull/36/c220477418%40github.com?utm_medium=email&utm_source=footer . For more options, visit https://groups.google.com/d/optout.
Also I think the account situation is a little messed up I'll fix it later.
On Thu, May 19, 2016, 8:35 PM hack4impactadmin notifications@github.com wrote:
Did you fetch first?
On Thu, May 19, 2016, 7:35 PM Anosha Minai notifications@github.com wrote:
@sandlerben https://github.com/sandlerben Addressed comments, also I thought I addressed conflicts but apparently not. When I call 'git merge origin/master' it says everything is up to date - what else do I need to do?
—
You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/hack4impact/transcribe4all/pull/36#issuecomment-220477418
You received this message because you are subscribed to the Google Groups "hack4impact-exec-2016-17" group. To unsubscribe from this group and stop receiving emails from it, send an email to hack4impact-exec-2016-17+unsubscribe@googlegroups.com. To post to this group, send email to hack4impact-exec-2016-17@googlegroups.com. To view this discussion on the web visit
https://groups.google.com/d/msgid/hack4impact-exec-2016-17/hack4impact/transcribe4all/pull/36/c220477418%40github.com < https://groups.google.com/d/msgid/hack4impact-exec-2016-17/hack4impact/transcribe4all/pull/36/c220477418%40github.com?utm_medium=email&utm_source=footer
. For more options, visit https://groups.google.com/d/optout.
— You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/hack4impact/transcribe4all/pull/36#issuecomment-220488888
@sandlerben Okay all fixed! I moved the Sphinx stuff into a sphinx.go folder, I need to add the MakeSphinxTaskFunction method but I will do that in a separate PR. Let me know what you think and then I'll merge.
Added a few comments, besides that lgtm
@sandlerben @roornelas
This PR is an extension of #26 - the function to run the command is now fixed in this PR, but I can also fix it in #26 if that's less confusing. There are two main new things: 1) StartTranscription runs a command and returns a string which is the output file name where the output is stored and 2) the func transcriptionOutputToStruct was created which reads a file (with the output) and creates a go struct.