hack4impact-utk / mission-of-hope

Repo for the Mission of hope project for Hack4impact

2 stars 0 forks source link

7 validate/fix typescript types and mongoose models #212

Closed Frank-D-stein closed 1 month ago

Frank-D-stein commented 1 month ago

Description

verified mongoose types lined up with drawio schema
verified each database interaction/API to have the correct three ts types
verified request types for mongoose models
verified fetch API calls use the correct response type
verified explicit return type on database functions
have donor be its own datatype and no longer extend off of person

Relevant issue(s)

7 (https://github.com/hack4impact-utk/Maintenance-Team/issues/7)

Questions

settings API call does not exist but is called in settings view, should I make an issue?
zip is kept as a number and string due to "form validation" as mentioned in a comment, Shouldn't zip just be a string? I did not change it yet because I wanted some more input.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have assigned reviewers to this PR