search

hack4impact / flask-base

A simple Flask boilerplate app with SQLAlchemy, Redis, User Authentication, and more.
http://hack4impact.github.io/flask-base
MIT License
3.04k stars 481 forks source link

Heroku bundling issues #199

Closed MapZombie closed 4 years ago

MapZombie commented 4 years ago

Hi, I am having a similar issue with #110, it seems like script ordering problems. This is after pushing to a heroku app. However as localhost everything renders correctly and does not throw the same errors. Has anybody run into script bundling issues this when deploying to Heroku?


Uncaught SyntaxError: Unexpected token '!'
dashboard.js:1000 Uncaught TypeError: $(...).jsGrid is not a function
    at creategrid (dashboard.js:1000)
    at dashboard.js:1069
creategrid @ dashboard.js:1000
(anonymous) @ dashboard.js:1069

jquery-3.4.1.min.js:2 Uncaught TypeError: $(...).sortable is not a function
    at HTMLDocument.<anonymous> (dashboard.js:59)
    at e (jquery-3.4.1.min.js:2)
    at t (jquery-3.4.1.min.js:2)
abhisuri97 commented 4 years ago

Are you seeing any other errors? Dashboard.js doesn't look like a dependency we have, so perhaps you should adjust app/assets.py to account for that file existing.

https://github.com/hack4impact/flask-base/blob/a10c66a16d46b04dbdf34ddced0387a080ce0b99/app/assets.py#L9

abhisuri97 commented 4 years ago

Closing unless there are any other issues (feel free to reopen as you see fit).