hack4reno2013 / RenoTracks-iOS

The live repo is here
https://github.com/nevada-bicycle-coalition/RenoTracks_iOS
GNU General Public License v3.0
0 stars 0 forks source link

All trips are being posted with the same device ID? #3

Closed cyberhobo closed 10 years ago

cyberhobo commented 10 years ago

Wish I had caught this sooner, seems to have been a problem in the beta and production versions. It looks like all trips are coming in with this device ID:

0f607264fc6318a92b9e13c65db7cd3c

As a result we're not able to distinguish individual users - it looks like everyone is using the same phone. @mtnbikerbrad, let me know if I can provide any more useful data!

colinloretz commented 10 years ago

[[UIDevice currentDevice] uniqueGlobalDeviceIdentifier] in the AppDelegate was deprecated. It still returns an ID but it is not one unique to the phone.

We ran into this with one of our own apps.

In iOS 7, Apple now always returns a fixed value when querying the MAC to specifically thwart the MAC as base for an ID scheme. So you now should use -[UIDevice identifierForVendor]. If the user uninstalls and reinstalls the app, it will be a new device id.

If you are keeping a record of the actual user in the RenoTracksHub, you can see if the token has changed and update as necessary.

theHellyar commented 10 years ago

Yeah I remember wen this changed, I will get in this, just have to burn thru some tedious homework. Thanks for the potential fix!

On February 8, 2014 at 9:54:08 AM PST, Colin Loretz wrote:[[UIDevice currentDevice] uniqueGlobalDeviceIdentifier] in the AppDelegate was deprecated. It still returns an ID but it is not one unique to the phone. We ran into this with one of our own apps. —Reply to this email directly or view it on GitHub.

colinloretz commented 10 years ago

:+1:

jrbj commented 10 years ago

To be more specific, [[UIDevice currentDevice] uniqueGlobalDeviceIdentifier] was removed from the SDK.

It’s a little different, but the method to get the hardware MAC address for a device still works. It just always returns the same number.

https://developer.apple.com/news/?id=8222013a

John Jusayan Reno Collective http://renocollective.com

On Feb 8, 2014, at 11:48 AM, mtnbikerbrad notifications@github.com wrote:

Yeah I remember wen this changed, I will get in this, just have to burn thru some tedious homework. Thanks for the potential fix!

On February 8, 2014 at 9:54:08 AM PST, Colin Loretz wrote:[[UIDevice currentDevice] uniqueGlobalDeviceIdentifier] in the AppDelegate was deprecated. It still returns an ID but it is not one unique to the phone. We ran into this with one of our own apps. —Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.

theHellyar commented 10 years ago

I think I fixed it but wanted to get your feedback on the best way to make the ID save even if the application is deleted and reinstalled? Or is this a non-issue?

jrbj commented 10 years ago

There isn't a way to prevent this. As far as I know it's by design to improve user privacy.

John Jusayan Reno Collective LLC http://renocollective.com

On Feb 8, 2014, at 6:20 PM, mtnbikerbrad notifications@github.com wrote:

I think I fixed it but wanted to get your feedback on the best way to make the ID save even if the application is deleted and reinstalled? Or is this a non-issue?

— Reply to this email directly or view it on GitHub.

cyberhobo commented 10 years ago

Let me know if you submit a trip I can use to verify the fix. Don't know if would be easy to submit fake data to the staging site or not...

On Sat, Feb 8, 2014 at 8:38 PM, John Jusayan notifications@github.comwrote:

There isn't a way to prevent this. As far as I know it's by design to improve user privacy.

John Jusayan Reno Collective LLC http://renocollective.com

On Feb 8, 2014, at 6:20 PM, mtnbikerbrad notifications@github.com wrote:

I think I fixed it but wanted to get your feedback on the best way to make the ID save even if the application is deleted and reinstalled? Or is this a non-issue?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/hack4reno2013/RenoTracks-iOS/issues/3#issuecomment-34565377 .

theHellyar commented 10 years ago

Fixed