hackademix / noscript

The popular NoScript Security Suite browser extension.
https://noscript.net/
GNU General Public License v3.0
852 stars 91 forks source link

togglePermissions is noop #129

Open woky opened 4 years ago

woky commented 4 years ago

NoScript provides togglePermissions command, available in shortcuts as Toggle Permissions. However it does not work no matter which key combo is assigned to it. This is because it does nothing: https://github.com/hackademix/noscript/blob/e2f7de8/src/bg/main.js#L89

PF4Public commented 1 year ago

It would be very useful if this key binding did function for temporarily toggling permissions for a tab. It would take only one keyboard shortcut to do this instead of two.

michaelfresco commented 1 year ago

I'm glad that you wrote this down here, because I have the same problem

hackademix commented 1 year ago

Please check 11.4.16rc1, thanks.

PF4Public commented 1 year ago

Please check 11.4.16rc1, thanks.

Thanks for the feature, when will it be available in extension stores?

PF4Public commented 1 year ago

@hackademix received update, now toggling tab permissions got unbelievably easy. Thanks a ton!