search

hackbg / chainlink-makerdao-automation

Chainlink Automation contracts for MakerDAO cron jobs
10 stars 7 forks source link

Approve DAI and LINK spending on init #25

Closed imollov closed 1 year ago

imollov commented 2 years ago

Instead of calling approve for DAI and LINK in the top up function

Ex: https://github.com/beefyfinance/beefy-contracts/blob/master/contracts/BIFI/keepers/contracts/UpkeepRefunder.sol#L150

mradkov commented 2 years ago

Infinite approvals are considered unsafe though. Keep in mind :)

imollov commented 1 year ago

Resolved in #65