search

hackbg / chainlink-makerdao-automation

Chainlink Automation contracts for MakerDAO cron jobs
10 stars 7 forks source link

feature: add setters for sequencer and network name #50

Closed ivaylonikolov7 closed 2 years ago

ivaylonikolov7 commented 2 years ago

resolves #40

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (9da74ea) into main (41e850e) will increase coverage by 1.25%. The diff coverage is 100.00%.

:exclamation: Current head 9da74ea differs from pull request most recent head a0019c5. Consider uploading reports for the commit a0019c5 to get more accurate results

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   94.51%   95.76%   +1.25%     
==========================================
  Files           8        8              
  Lines         164      189      +25     
  Branches       30       38       +8     
==========================================
+ Hits          155      181      +26     
+ Misses          9        8       -1
Impacted Files Coverage Δ
contracts/DssCronKeeper.sol 100.00% <100.00%> (ø)
contracts/DssVestTopUp.sol 95.65% <0.00%> (+0.86%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ivaylonikolov7 commented 2 years ago

Not sure if protected means they should be internal as in terms of OOP or if protected means it should be only called by owner of the contract. For now I did it as the latter if necessary I can change It to the other way.