search

hackclub / OnBoard

💡 Join 1,000 teenagers and make your first PCB with a $100 grant!
https://hackclub.com/onboard/
738 stars 827 forks source link

I got the grant - Files still unmerged #1068

Closed DefinetlyNotAI closed 1 month ago

DefinetlyNotAI commented 1 month ago

I already got the grant, but i dont know why the pr didnt get accepted?

Can you just merge this - No grant needed

LimesKey commented 1 month ago

Do you mean this PR https://github.com/hackclub/OnBoard/pull/993 ? It was merged

DefinetlyNotAI commented 1 month ago

Hmm, this is 19 commits vs the 17 commits...

Not sure tho

DefinetlyNotAI commented 1 month ago

GitGuardian says the npmrc file has a vuln, this was given to me when i updated this branch

image

blazecoding2009 commented 1 month ago

I can see commits were made but these were already merged. No files were changed afterwards. I'll be closing this now.

DefinetlyNotAI commented 1 month ago

Thx