search

hackclub / contribute

A list of active Hack Club open source repositories with available issues on GitHub
http://contribute.hackclub.com
MIT License
13 stars 6 forks source link

Format with Prettier #19

Closed exu3 closed 2 years ago

exu3 commented 2 years ago

This PR adds a Prettier configuration file (following the style of the existing code - semicolons, double quotes, etc).

I have "format on save" enabled, and I noticed that my own Prettier config kept formatting all the files in a different style, so this PR just adds a configuration scoped to this project to keep things consistent.

This is sort of opinionated, not sure if it's desired.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hackclub/contribute/7QRv6eoRXpsuWKQo8zJNcMq79BxL
✅ Preview: https://contribute-git-exu-prettier.hackclub.dev

jessicard commented 2 years ago

Ooooh interesting! I'll let you and @sampoder decide if this makes sense, as you all have precedent on what we've done on other Hack Club repositories :)

jessicard commented 2 years ago

@exu3 One concern I have is that, since this is a static site, people won't have prettier running on their machines. We could add instructions, but that makes a simple site a bit more complicated. So it'd be an optional prettier config, which is a bit odd. I'm not sure! What are your thoughts?

exu3 commented 2 years ago

This configuration file won't do anything if you don't use Prettier. I think some people just might not be clear on what this file does, but it shouldn't cause any issues or require additional setup.

exu3 commented 2 years ago

Totally cool with closing this PR if it makes things more confusing!