hackclub / high-seas

🏴‍☠️ It's better to be a pirate than join the navy!
https://highseas.hackclub.com
67 stars 17 forks source link

“Screenshot URL” should just be an image upload component #197

Open polytroper opened 1 month ago

polytroper commented 1 month ago

Asking for a screenshot URL introduces an annoying barrier to people who then need to find a way to upload a screenshot. Instead it should just be an image upload component. We will have to decide whether we want to store images as URLs or convert those fields to attachments (or have either option on the backend).

Bonus: include instructions for how to do a screenshot on various platforms.

This is technically not strictly required for launch but would be a great change to have since it impacts how we build the tutorial, and it is therefore less work overall to do it now. If we are not able to implement before launch, then we will just have to tell people to post screenshots to the CDN channel.

aramshiva commented 1 month ago

Does #cdn have an API?

cskartikey commented 1 month ago

We can cdnise it? #cdn has an API

On Fri, Oct 25, 2024, 05:57 Aram @.***> wrote:

Does #cdn have an API?

— Reply to this email directly, view it on GitHub https://github.com/hackclub/high-seas/issues/197#issuecomment-2436568001, or unsubscribe https://github.com/notifications/unsubscribe-auth/APPLBVIESZCDB32LFEQJ3TLZ5GGA3AVCNFSM6AAAAABQRXGNO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGU3DQMBQGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

aramshiva commented 1 month ago

Where is the CDN API documentation?

polytroper commented 1 month ago

@aramshiva Don't even bother waiting for it. Just insert the file into this handy new screenshot attachment field on the airtable and then put the URL for the attachment into screenshot_url

aramshiva commented 1 month ago

K, will work on when #289 gets resolved

polytroper commented 1 month ago

It's a write, a read, and then a write instead of just a write but it will work ¯_(ツ)_/¯

aramshiva commented 1 month ago

hmm, one problem is we don't have a way to delete the uploaded files because then we would need to give each item a file id, to delete files. unless we process everything at the submit which may be hard

aramshiva commented 1 month ago

actually -- never mind, I could just base64 encode the image and upload that to airtable

polytroper commented 1 month ago

@aramshiva let's make this a "One week in" feature. We do want it though

Gitstar-OC commented 1 week ago

Alright, I can work on it. @maxwofford could you check message I sent you https://hackclub.slack.com/archives/D080WSBBRMY/p1732023290572009