hackclub / high-seas

🏴‍☠️ It's better to be a pirate than join the navy!
https://highseas.hackclub.com
40 stars 10 forks source link

Add hours logged in to The Sign Post #591

Closed cskartikey closed 1 week ago

cskartikey commented 2 weeks ago

should close #591

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 9:51pm
cskartikey commented 1 week ago

I don't see it being passed anywhere from where I can pass it down

On Fri, Nov 1, 2024, 22:02 Max Wofford @.***> wrote:

@.**** commented on this pull request.

In src/app/harbor/signpost/signpost.tsx https://github.com/hackclub/high-seas/pull/591#discussion_r1826033829:

@@ -30,6 +31,13 @@ export default function SignPost({ session }: { session: any }) {

useEffect(() => { fetchWaka().then(({ key }) => setWakaKey(key));

  • const initHours = async () => {
  • const sessions = await getWakaSessions();

I meant passing it down– I believe it's already being called on page load!

— Reply to this email directly, view it on GitHub https://github.com/hackclub/high-seas/pull/591#discussion_r1826033829, or unsubscribe https://github.com/notifications/unsubscribe-auth/APPLBVLCQNA5U3T7G3X27HLZ6OUK7AVCNFSM6AAAAABQ7GBZH2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJQGQZTOOBYG4 . You are receiving this because you authored the thread.Message ID: @.***>

malted commented 1 week ago

Thank you for the PoC! :) Resolved in https://github.com/hackclub/high-seas/pull/623