hackclub / sinerider

đź’– A game about love and graphing, built by teenagers.
https://sinerider.com
GNU Affero General Public License v3.0
548 stars 46 forks source link

[FEATURE] Save Game via Email #242

Open alhardwarehyde opened 1 year ago

alhardwarehyde commented 1 year ago

Description

From 3/15 Meeting with @polytroper

Box Pops Up to Save via Email (note, when do we want that to happen?)

Screenshots

No response

Additional information

No response

alhardwarehyde commented 1 year ago

@polytroper @profsucrose decide if we want to do this or save via local storage

alhardwarehyde commented 1 year ago

Moving this to after ship

profsucrose commented 1 year ago

Sorry what's the point of saving this via email over just localStorage/URLs? (If that entails emailing the actual solution and/or link to the user, who then "saves" it through clicking on a modal and entering their email or whatever). If there is a good reason to do so then we could certainly implement it, though I agree that it should be a feature added after ship

polytroper commented 1 year ago

It’s just a way to give an “official” save button that is not tied to a specific machine. Users can of course copy the URL, but “enter email to save” is easier to communicate in the UI. And of course we can include easy 1-click links to join the newsletter or daily puzzle mailing list in the saved game emails.

On Mon, Apr 3, 2023 at 12:48 PM Prof. Sucrose @.***> wrote:

Sorry what's the point of saving this via email over just localStorage/URLs? (If that entails emailing the actual solution and/or link to the user, who then "saves" it through clicking on a modal and entering their email or whatever). If there is a good reason to do so then we could certainly implement it, though I agree that it should be a feature added after ship

— Reply to this email directly, view it on GitHub https://github.com/hackclub/sinerider/issues/242#issuecomment-1494884638, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADX6AEL4TCGQRY3P2AVE223W7MSRTANCNFSM6AAAAAAV5RFWFM . You are receiving this because you were mentioned.Message ID: @.***>

camdan-me commented 1 year ago

I don't remember where my discussion with Chris took place, but the idea is a backup of a user's progress. Serializing everything in the URL doesn't make much sense because it makes sharing solutions more difficult, but game data backups are still important.

profsucrose commented 1 year ago

Again this is probably something only worth worrying about after ship, but if SineRider has a dedicated microservice anyway for the scoring server, maybe we could also use that for storing solutions? (Maybe as like both a dedicated link shortner for sharing solutions and also as a way for someone to manage their set of solutions under their username or whatever; though this might also detract from using Twitter which iirc is supposed to be the crux of the game? Idk just thinking out loud). However I still think that localStorage/URLs are good enough for tracking solutions on a single machine/browser and for easily sharing them with others for now

camdan-me commented 1 year ago

We can do a rudimentary oauth-based login system (twitter, discord, google), but that'd definitely be after ship cause implementing Google oauth sucks.