search

hackclub / sinerider

💖 A game about love and graphing, built by teenagers.
https://sinerider.com
GNU Affero General Public License v3.0
553 stars 46 forks source link

[FEATURE] Enter button should proceed to next level from success screen #327

Open camdan-me opened 1 year ago

camdan-me commented 1 year ago

Description

Related to #64, #304

Screenshots

No response

Additional information

No response

polytroper commented 1 year ago

I have mixed feelings on this. On the one hand, this feels right when you are playing "story mode". On the other hand, when you are trying to work out an optimal solution for a particular level you don't want it skipping to the next level. How strongly do you believe this is the correct default?

camdan-me commented 1 year ago

What if escape resets? I feel like enter continuing is the logical thing for the button to do.

polytroper commented 1 year ago

It feels like a simpler default to have it only ever do one thing, start/stop. We could make spacebar trigger the next level, and label it in the UI somewhere?

camdan-me commented 1 year ago

That's an option, I'm just gonna play devil's advocate one more time

Enter is always having the same function, a function of progressing forward. On khan, for example, enter submits your question, and pressing it again proceeds to the next question.

alhardwarehyde commented 1 year ago

@polytroper thoughts? Especially because whatever call we make will need to be resolved in a week

alhardwarehyde commented 1 year ago

Moving this to After Ship for now!

josephdong1000 commented 1 year ago

I'm of the belief that pressing enter after you win is a natural sequence of keypresses and would intuitively take you back to the level select area. Several people did this when I showed the game around to my friends. Instead of optimizing for the small crowd of minimum-time players, we should enhance the new player experience and smooth out the play-test-win loop. If anything, binding a different key like Escape or shift+enter to edit the equation would cater towards the minimum-time crowd, if you consider how hotkeys are implemented in UI.