hackclub / sinerider

💖 A game about love and graphing, built by teenagers.
https://sinerider.com
GNU Affero General Public License v3.0
568 stars 47 forks source link

Handle case of puzzle submission exceeding time limit #484

Closed exu3 closed 1 year ago

exu3 commented 1 year ago

Description

When tweeting my puzzle submission, I got a generic error message (the real issue was that my solve exceeded the time limit). The error message should say that there was an error with my submission because it exceeded the time cap of 30 seconds.

This is the url of my submission. https://sinerider.hackclub.dev/?N4IgdghgtgpiBcIAiECWAbAngAgAoFcAvQ9GbAYgEYQAacVAYwGsEQAHIkmAfWroBMAThADuAeUH8YghJQAMCuXQAeCALTy6mBEpBSAZhHzoALgFFlbQTADON1AHswrObRABzBxHQ2EAbVBVeABWLXUANjoTTDY4RH1UZRh+EABfGkCEABYw+A1daNjWBKSUugdJaVYAITSMkCDdbXhKACYomLiQEuS6zLzKHJBmtSHCrp6ykAqpGURa9P6ATly1UJBx4sTe8sq5kABBNIBdOhtSflnfeACG2QBmOgg7GBNWVCgId1sAOgh+CDcc69VKnEAAI0csFY6Ac7lQNhMjCQ+DAtjcCIIxFICBMgnwMDoMEs1jsjjAYgAbtJBKgpKwfpQADpM0j6EwACmUAGosizae4ABYmACUAD1WtyTGpWsE0kA=

Screenshots

Screenshot 2023-05-04 at 2 37 08 PM

Additional information

no

grymmy commented 1 year ago

@developedbytoby any chance you could look into this? I looked at the logs and it looked like the scoring service was timing out the solution (>30 sec) but the bot responded with the generic error?

grymmy commented 1 year ago

Nevermind @developedbytoby - @JosiasAurel per our conversation, please look into reverting https://github.com/JosiasAurel/sinerider-scoring/commit/35b371e33a6e957a79931b71631090f649eddc1e which caused a regression in scoring solutions that exceed the timeout threshold

JosiasAurel commented 1 year ago

PR https://github.com/JosiasAurel/sinerider-scoring/pull/17

alhardwarehyde commented 1 year ago

@JosiasAurel does this mean it's good to close?

JosiasAurel commented 1 year ago

yes @alhardwarehyde