search

hackclub / sinerider

💖 A game about love and graphing, built by teenagers.
https://sinerider.com
GNU Affero General Public License v3.0
548 stars 46 forks source link

Expressions Not Showing Up Properly in Leaderboard #555

Closed alhardwarehyde closed 1 year ago

alhardwarehyde commented 1 year ago

Description

05/10/23 Expressions should be formatted as they are in game

Screenshots

Screenshot 2023-05-10 at 10 08 03 AM

Additional information

No response

ivoinestrachan commented 1 year ago

@grymmy told me to add a elipsis on it be it extends to long @alhardwarehyde

grymmy commented 1 year ago

@grymmy told me to add a elipsis on it be it extends to long @alhardwarehyde

To be clear - the goal is for it to "look good" - truncation in extreme cases of lengthy expressions seems reasonable...

ivoinestrachan commented 1 year ago

alright thank you for the explanation!

alhardwarehyde commented 1 year ago

@JosiasAurel @ivoinestrachan is this issue solved?

JosiasAurel commented 1 year ago

I think it is. @ivoinestrachan you can merge my PR if it's okay to you

ivoinestrachan commented 1 year ago

oh let me check it out sorry abt that